[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20121227173233.GI5005@opensource.wolfsonmicro.com>
Date: Thu, 27 Dec 2012 17:32:33 +0000
From: Mark Brown <broonie@...nsource.wolfsonmicro.com>
To: Laxman Dewangan <ldewangan@...dia.com>
Cc: grant.likely@...retlab.ca, rob.herring@...xeda.com, lrg@...com,
devicetree-discuss@...ts.ozlabs.org, linux-doc@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 1/2] regulator: tps51632: add register property for
regmap
On Tue, Dec 25, 2012 at 08:35:59PM +0530, Laxman Dewangan wrote:
> All TPS51632 registers are not readable/writable and
> non-volatiles.
Applied both, thanks, but you might wish to consider...
> +static bool is_read_reg(struct device *dev, unsigned int reg)
> +{
> + switch (reg) {
> + case 0x08 ... 0x0F:
> + return false;
> + default:
> + return true;
> + }
> +}
...using the new table based stuff for the access checks, at least this
one seems to map on nicely.
Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)
Powered by blists - more mailing lists