lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1356716033.31130.10.camel@joe-AO722>
Date:	Fri, 28 Dec 2012 09:33:53 -0800
From:	Joe Perches <joe@...ches.com>
To:	Anders Larsen <al@...rsen.net>
Cc:	Masanari Iida <standby24x7@...il.com>, trivial@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [trivial]treewide: Fix typo in various drivers

On Fri, 2012-12-28 at 17:39 +0100, Anders Larsen wrote:
> On 2012-12-28 16:49, Masanari Iida wrote:
> > Correct spelling typo in printk within various drivers.
> > ---
> > diff --git a/net/caif/cfcnfg.c b/net/caif/cfcnfg.c
[]
> > @@ -402,7 +402,7 @@ cfcnfg_linkup_rsp(struct cflayer *layer, u8  
> > channel_id, enum cfctrl_srv serv,
> > 
> >  	phyinfo = cfcnfg_get_phyinfo_rcu(cnfg, phyid);
> >  	if (phyinfo == NULL) {
> > -		pr_err("ERROR: Link Layer Device dissapeared"
> > +		pr_err("ERROR: Link Layer Device dissappeared"
> 
> that should rather be
> +		pr_err("ERROR: Link Layer Device disappeared"
> 
> >  				"while connecting\n");

Instead use:

		pr_err("ERROR: Link Layer Device disappeared while connecting\n");

so there a space between before while
and it's easier to grep

Because it's already pr_err, I think the
"ERROR: " prefix doesn't have any added
value either.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ