linux-kernel - Re: [PATCH] mips: Export min_low_pfn if CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 28 Dec 2012 22:44:48 +0100
From:	Ralf Baechle <ralf@...ux-mips.org>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mips: Export min_low_pfn if CONFIG_FLATMEM

On Fri, Dec 28, 2012 at 09:40:56PM +0100, Geert Uytterhoeven wrote:

> Subject: [PATCH] mips: Export min_low_pfn if CONFIG_FLATMEM
> 
> If CONFIG_FLATMEM=y on MIPS, pfn_valid() (and thus virt_addr_valid()) uses
> min_low_pfn. However, min_low_pfn is not exported by the generic bootmem
> code.
> 
> As of commit e52a29326462badd9ceec90a9eb2ac2a8550e02e ("aoe: avoid races
> between device destruction and discovery"), aoeblk_open() uses
> virt_addr_valid(), causing a link error in the modular case:
> 
>     ERROR: "min_low_pfn" [drivers/block/aoe/aoe.ko] undefined!
> 
> Add a custom export to fix this, just like is done for ia64 in
> arch/ia64/kernel/ia64_ksyms.c.
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> ---
> http://kisskb.ellerman.id.au/kisskb/buildresult/7864918/
> 
>  arch/mips/kernel/mips_ksyms.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/mips/kernel/mips_ksyms.c b/arch/mips/kernel/mips_ksyms.c
> index df1e3e4..8579bb8 100644
> --- a/arch/mips/kernel/mips_ksyms.c
> +++ b/arch/mips/kernel/mips_ksyms.c
> @@ -60,3 +60,8 @@ EXPORT_SYMBOL(invalid_pte_table);
>  /* _mcount is defined in arch/mips/kernel/mcount.S */
>  EXPORT_SYMBOL(_mcount);
>  #endif
> +
> +#ifdef CONFIG_FLATMEM
> +#include <linux/bootmem.h>
> +EXPORT_SYMBOL(min_low_pfn);	/* defined by bootmem.c, but not exported by generic code */
> +#endif

I've already applied a different patch which turns virt_addr_valid() into
a normal function and exports it.

Thanks,

  Ralf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/