lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CA+icZUV1kOPogpd6cuwUUFy=MK8AqArVW+XgAPDLpAKyWLUShg@mail.gmail.com> Date: Sat, 29 Dec 2012 09:45:27 +0100 From: Sedat Dilek <sedat.dilek@...il.com> To: Zlatko Calusic <zlatko.calusic@...on.hr> Cc: Andrew Morton <akpm@...ux-foundation.org>, Mel Gorman <mgorman@...e.de>, Linus Torvalds <torvalds@...ux-foundation.org>, Hugh Dickins <hughd@...gle.com>, linux-mm <linux-mm@...ck.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Zhouping Liu <zliu@...hat.com> Subject: Re: [PATCH] mm: fix null pointer dereference in wait_iff_congested() Just FYI: This patch landed upstream [1]. Thanks for all involved people. - Sedat - [1] http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commitdiff;h=ecccd1248d6e6986130ffcc3b0d003cb46a485c0 On Fri, Dec 28, 2012 at 3:16 AM, Zlatko Calusic <zlatko.calusic@...on.hr> wrote: > From: Zlatko Calusic <zlatko.calusic@...on.hr> > > The unintended consequence of commit 4ae0a48b is that > wait_iff_congested() can now be called with NULL struct zone* > producing kernel oops like this: > > BUG: unable to handle kernel NULL pointer dereference > IP: [<ffffffff811542d9>] wait_iff_congested+0x59/0x140 > > This trivial patch fixes it. > > Reported-by: Zhouping Liu <zliu@...hat.com> > Reported-and-tested-by: Sedat Dilek <sedat.dilek@...il.com> > Cc: Andrew Morton <akpm@...ux-foundation.org> > Cc: Mel Gorman <mgorman@...e.de> > Cc: Hugh Dickins <hughd@...gle.com> > Signed-off-by: Zlatko Calusic <zlatko.calusic@...on.hr> > --- > mm/vmscan.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 02bcfa3..e55ce55 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -2782,7 +2782,7 @@ loop_again: > if (total_scanned && (sc.priority < DEF_PRIORITY - 2)) { > if (has_under_min_watermark_zone) > count_vm_event(KSWAPD_SKIP_CONGESTION_WAIT); > - else > + else if (unbalanced_zone) > wait_iff_congested(unbalanced_zone, BLK_RW_ASYNC, HZ/10); > } > > -- > 1.8.1.rc3 > > -- > Zlatko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists