linux-kernel - Re: [PATCH] USB: misc: Add USB3503 High-Speed Hub Controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121231032200.GA5769@kroah.com>
Date:	Sun, 30 Dec 2012 19:22:00 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Dongjin Kim <tobetter@...il.com>
Cc:	Grant Likely <grant.likely@...retlab.ca>,
	Rob Herring <rob.herring@...xeda.com>,
	René Bürgel <rene.buergel@...ard.de>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	devicetree-discuss@...ts.ozlabs.org
Subject: Re: [PATCH] USB: misc: Add USB3503 High-Speed Hub Controller

On Mon, Dec 31, 2012 at 11:50:54AM +0900, Dongjin Kim wrote:
> This patch adds new driver of SMSC USB3503 USB 2.0 hub controller with HSIC
> upstream connectivity and three USB 2.0 downstream ports. The specification
> can be found from 'http://www.smsc.com/index.php?tid=295&pid=325'.
> 
> The current version have been tested very basic features switching the modes,
> HUB-MODE and STANDBY-MODE.

What causes the modes to be switched?  From reading the driver, that
only seems possible to do at boot/load time when the driver reads the
platform data, right?  After that, nothing happens to the device from
what I can tell.

Is something going to cause the state of the device to change in the
future?

> +		hub->mode = mode;
> +		dev_info(&i2c->dev, "switched to HUB mode\n");

Can you please switch all of the dev_info() calls to dev_dbg()?  There's
no need to tell the world what is going on in this driver, no one really
cares.  And if they do, they can dynamically enable debugging and get
the information then :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/