linux-kernel - Re: [PATCH] staging:iio:adis16260: select IIO_ADIS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50E13BBA.1000801@metafoo.de>
Date:	Mon, 31 Dec 2012 08:16:10 +0100
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Yuanhan Liu <yuanhan.liu@...ux.intel.com>
CC:	linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, Jonathan Cameron <jic23@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] staging:iio:adis16260: select IIO_ADIS_LIB to fix build
 error

On 12/31/2012 06:36 AM, Yuanhan Liu wrote:
> Commit 9d5e9fdf turned the code to use adis library, so it depends on
> adis lib. But it forgot to select it at Kconfig file. Thus if adis is
> not enabled, it will produce following build errros(catched by Fengguang's
> 0-DAY kernel build testing system):
>   ERROR: "adis_initial_startup" [drivers/staging/iio/gyro/adis16260.ko] undefined!
>   ERROR: "adis_init" [drivers/staging/iio/gyro/adis16260.ko] undefined!
>   ERROR: "adis_write_reg" [drivers/staging/iio/gyro/adis16260.ko] undefined!
>   ERROR: "adis_read_reg" [drivers/staging/iio/gyro/adis16260.ko] undefined!
>   ERROR: "adis_single_conversion" [drivers/staging/iio/gyro/adis16260.ko] undefined!
> 
> Selecting IIO_ADIS_LIB at Kconfig file fixes this issue.
> 
> Reported-by: Fengguang Wu <fengguang.wu@...el.com>
> Cc: Lars-Peter Clausen <lars@...afoo.de>
> Cc: Jonathan Cameron <jic23@...nel.org>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Yuanhan Liu <yuanhan.liu@...ux.intel.com>

Hi,

Thanks. But I already sent a similar patch some time ago. See
http://www.spinics.net/lists/linux-iio/msg07128.html

- Lars

> ---
>  drivers/staging/iio/gyro/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/staging/iio/gyro/Kconfig b/drivers/staging/iio/gyro/Kconfig
> index ea295b2..476207a 100644
> --- a/drivers/staging/iio/gyro/Kconfig
> +++ b/drivers/staging/iio/gyro/Kconfig
> @@ -27,6 +27,7 @@ config ADIS16130
>  config ADIS16260
>  	tristate "Analog Devices ADIS16260 Digital Gyroscope Sensor SPI driver"
>  	depends on SPI
> +	select IIO_ADIS_LIB
>  	select IIO_TRIGGER if IIO_BUFFER
>  	select IIO_SW_RING if IIO_BUFFER
>  	help

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/