linux-kernel - Re: [PATCH] vfs: Add missing errno.h inclusion to namei.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130102084205.2320f6b9@tlielax.poochiereds.net>
Date:	Wed, 2 Jan 2013 08:42:05 -0500
From:	Jeff Layton <jlayton@...hat.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Al Viro <viro@...iv.linux.org.uk>, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org,
	Stephen Warren <swarren@...dotorg.org>,
	"Theodore Ts'o" <tytso@....edu>
Subject: Re: [PATCH] vfs: Add missing errno.h inclusion to namei.h

On Wed,  2 Jan 2013 13:36:26 +0000
Mark Brown <broonie@...nsource.wolfsonmicro.com> wrote:

> In current -next namei.h now include/linux/namei.h uses ESTALE but does
> not include errno.h, leading to build failures on ARM where errno.h is
> not previously implicitly included by some other header as is the case
> in some bits of ext3. Fix this by adding a direct inclusion of errno.h.
> 
> Signed-off-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>
> ---
>  include/linux/namei.h |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/namei.h b/include/linux/namei.h
> index e998c03..5a5ff57 100644
> --- a/include/linux/namei.h
> +++ b/include/linux/namei.h
> @@ -2,6 +2,7 @@
>  #define _LINUX_NAMEI_H
>  
>  #include <linux/dcache.h>
> +#include <linux/errno.h>
>  #include <linux/linkage.h>
>  #include <linux/path.h>
>  

I think Ted and Stephen (cc'ed here) proposed the same patch a week or
so ago, but I'm not sure why Al hasn't pushed it yet.

-- 
Jeff Layton <jlayton@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/