linux-kernel - Re: [PATCH] debugfs: convert gid= argument from decimal, not octal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130102183351.GA28554@kroah.com>
Date:	Wed, 2 Jan 2013 10:33:51 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Dave Reisner <dreisner@...hlinux.org>, keescook@...omium.org
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] debugfs: convert gid= argument from decimal, not octal

On Wed, Jan 02, 2013 at 08:54:37AM -0500, Dave Reisner wrote:
> This patch technically breaks userspace, but I suspect that anyone who
> actually used this flag would have encountered this brokenness, declared
> it lunacy, and already sent a patch.

Kees is the one that originally did this change (I think, right?)

Kees, any objection to this patch?  Will it break your existing systems?

thanks,

greg k-h

> 
> Signed-off-by: Dave Reisner <dreisner@...hlinux.org>
> ---
>  fs/debugfs/inode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c
> index 153bb1e..a5f12b7 100644
> --- a/fs/debugfs/inode.c
> +++ b/fs/debugfs/inode.c
> @@ -176,7 +176,7 @@ static int debugfs_parse_options(char *data, struct debugfs_mount_opts *opts)
>  			opts->uid = uid;
>  			break;
>  		case Opt_gid:
> -			if (match_octal(&args[0], &option))
> +			if (match_int(&args[0], &option))
>  				return -EINVAL;
>  			gid = make_kgid(current_user_ns(), option);
>  			if (!gid_valid(gid))
> -- 
> 1.8.0.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/