[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20130102185747.GA28762@kroah.com>
Date: Wed, 2 Jan 2013 10:57:47 -0800
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Kees Cook <keescook@...omium.org>
Cc: Dave Reisner <dreisner@...hlinux.org>,
LKML <linux-kernel@...r.kernel.org>,
Vasiliy Kulikov <segoon@...nwall.com>
Subject: Re: [PATCH] debugfs: convert gid= argument from decimal, not octal
On Wed, Jan 02, 2013 at 10:42:17AM -0800, Kees Cook wrote:
> On Wed, Jan 2, 2013 at 10:33 AM, Greg Kroah-Hartman
> <gregkh@...uxfoundation.org> wrote:
> > On Wed, Jan 02, 2013 at 08:54:37AM -0500, Dave Reisner wrote:
> >> This patch technically breaks userspace, but I suspect that anyone who
> >> actually used this flag would have encountered this brokenness, declared
> >> it lunacy, and already sent a patch.
> >
> > Kees is the one that originally did this change (I think, right?)
>
> I recommended the default change, but I think it was Vasiliy that
> added the gid option, IIRC.
Ah, you are right, sorry about that.
> > Kees, any objection to this patch? Will it break your existing systems?
>
> Regardless, I have no objection -- this should be int, not octal.
Ok, I'll queue this up when I get back from vacation next week.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists