linux-kernel - Re: [PATCH,staging/speakup] Prefix externally-visible symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130102013818.GI6582@type.youpi.perso.aquilenet.fr>
Date:	Wed, 2 Jan 2013 02:38:18 +0100
From:	Samuel Thibault <samuel.thibault@...-lyon.org>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	William Hubbs <w.d.hubbs@...il.com>,
	Chris Brannon <chris@...-brannons.com>,
	Kirk Reiser <kirk@...ille.uwo.ca>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH,staging/speakup] Prefix externally-visible symbols

Greg Kroah-Hartman, le Tue 01 Jan 2013 17:17:22 -0800, a écrit :
> On Tue, Jan 01, 2013 at 11:52:57PM +0100, Samuel Thibault wrote:
> > This prefixes all externally-visible symbols of speakup with "spk_".
> > (or makes static some of them which do not actually need to be
> > externally-visible)
> 
> Care to break this up into smaller pieces?  Like one for the variables
> that should just be static?  And then the other bits?

Done so.

> Also, I think you just changed user-visable variables/sysfs files, which
> isn't acceptable.  Be careful about that when you resend.

Oops, I thought these were variable references, but it's actually done
through callbacks indeed. Fixed.

Samuel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/