linux-kernel - Re: [PATCH 1/2] timer: vt8500: Move system timer to clocksource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201301030807.53550.arnd@arndb.de>
Date:	Thu, 3 Jan 2013 08:07:53 +0000
From:	Arnd Bergmann <arnd@...db.de>
To:	Joe Perches <joe@...ches.com>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Tony Prisk <linux@...sktech.co.nz>,
	Olof Johansson <olof@...om.net>, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	vt8500-wm8505-linux-kernel@...glegroups.com,
	John Stultz <johnstul@...ibm.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 1/2] timer: vt8500: Move system timer to clocksource

On Thursday 03 January 2013, Joe Perches wrote:
> Also I think it'd be nicer to write something like:
> 
>         struct device_node *np;
>         int timer_irq;
>         const char *reason;
> 
>         np = of_find_matching_node(NULL, vt8500_timer_ids);
>         if (!np) {
>                 reason = "timer";
>             goto error;
>         }
>         regbase = of_iomap(np, 0);
>         if (!regbase) {
>                 reason = "iobase";
>                 goto error_put;
>         }
>         timer_irq = irq_of_parse_and_map(np, 0);
>         if (!timer_irq) {
>                 reason = "irq";
>                 goto error_remap;
>         }
>  
>         ...
> 
> error_remap:
>         unmap...;
> error_put:
>         of_node_put(np);
> error:
>         pr_err("%s: Missing %s description in Device Tree\n",
>                __func__, reason);
>         return;

Right, but that would be a separate cleanup patch, since the patch that
Tony posted is just supposed to move the code around and change as little
else as possible in the process. The cleanup can come either right before
or right after the move.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/