lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20130103120129.GF8140@linux.vnet.ibm.com> Date: Thu, 3 Jan 2013 17:31:29 +0530 From: Srikar Dronamraju <srikar@...ux.vnet.ibm.com> To: Oleg Nesterov <oleg@...hat.com> Cc: Ingo Molnar <mingo@...e.hu>, Peter Zijlstra <peterz@...radead.org>, Ananth N Mavinakayanahalli <ananth@...ibm.com>, Anton Arapov <anton@...hat.com>, Frank Eigler <fche@...hat.com>, Josh Stone <jistone@...hat.com>, "Suzuki K. Poulose" <suzuki@...ibm.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/2] uprobes/x86: Change __skip_sstep() to actually skip the whole insn * Oleg Nesterov <oleg@...hat.com> [2012-12-30 16:47:19]: > __skip_sstep() doesn't update regs->ip. Currently this is correct > but only "by accident" and it doesn't skip the whole insn. Change > it to advance ->ip by the length of the detected 0x66*0x90 sequence. > > Signed-off-by: Oleg Nesterov <oleg@...hat.com> Acked-by: Srikar Dronamraju <srikar@...ux.vnet.ibm.com> > --- > arch/x86/kernel/uprobes.c | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/arch/x86/kernel/uprobes.c b/arch/x86/kernel/uprobes.c > index c71025b..4e33a35 100644 > --- a/arch/x86/kernel/uprobes.c > +++ b/arch/x86/kernel/uprobes.c > @@ -680,8 +680,11 @@ static bool __skip_sstep(struct arch_uprobe *auprobe, struct pt_regs *regs) > if (auprobe->insn[i] == 0x66) > continue; > > - if (auprobe->insn[i] == 0x90) > + if (auprobe->insn[i] == 0x90) { > + regs->ip = uprobe_get_swbp_addr(regs); > + regs->ip += i + 1; > return true; > + } > > break; > } > -- > 1.5.5.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists