lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1357231792.25181.62.camel@joe-AO722> Date: Thu, 03 Jan 2013 08:49:52 -0800 From: Joe Perches <joe@...ches.com> To: Andy Whitcroft <apw@...onical.com> Cc: Andrew Morton <akpm@...ux-foundation.org>, Lance Ortiz <lance.ortiz@...com>, bhelgaas@...gle.com, lance_ortiz@...mail.com, jiang.liu@...wei.com, tony.luck@...el.com, bp@...en8.de, rostedt@...dmis.org, mchehab@...hat.com, linux-acpi@...r.kernel.org, linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org Subject: [PATCH V2] checkpatch: prefer dev_<level>( to dev_printk(KERN_<LEVEL> Add YA check to printk style. dev_<level> uses are functions and generate smaller object code than dev_printk(KERN_<LEVEL>. Signed-off-by: Joe Perches <joe@...ches.com> --- V2: Remove unnecessary copy/paste logic from pr_<level> conversion above it. scripts/checkpatch.pl | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 9de3a69..9a1ae72 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2425,6 +2425,15 @@ sub process { "Prefer pr_warn(... to pr_warning(...\n" . $herecurr); } + if ($line =~ /\bdev_printk\s*\(\s*KERN_([A-Z]+)/) { + my $orig = $1; + my $level = lc($orig); + $level = "warn" if ($level eq "warning"); + $level = "dbg" if ($level eq "debug"); + WARN("PREFER_DEV_LEVEL", + "Prefer dev_$level(... to dev_printk(KERN_$orig, ...\n" . $herecurr); + } + # function brace can't be on same line, except for #defines of do while, # or if closed on same line if (($line=~/$Type\s*$Ident\(.*\).*\s{/) and -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists