linux-kernel - Re: [PATCH -v2 03/26] x86: pageattr-test: remove srandom32 call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50E5C167.2080908@zytor.com>
Date:	Thu, 03 Jan 2013 09:35:35 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Akinobu Mita <akinobu.mita@...il.com>
CC:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, x86@...nel.org
Subject: Re: [PATCH -v2 03/26] x86: pageattr-test: remove srandom32 call

On 01/03/2013 04:18 AM, Akinobu Mita wrote:
> pageattr-test calls srandom32() once every test iteration.
> But calling srandom32() after late_initcalls is not meaningfull.
> Because the random states for random32() is mixed by good random numbers
> in late_initcall prandom_reseed().
>
> So this removes the call to srandom32().
>
> Signed-off-by: Akinobu Mita <akinobu.mita@...il.com>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: "H. Peter Anvin" <hpa@...or.com>
> Cc: x86@...nel.org
> ---
>
> No change from v1
>

Acked-by: H. Peter Anvin <hpa@...or.com>

... for this and the other patch.  Do you need me to pick it up or are 
you pushing this directly as part of your bigger patchset?

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/