lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Thu, 3 Jan 2013 10:37:59 -0800
From:	Bryan Wu <cooloney@...il.com>
To:	"Kim, Milo" <Milo.Kim@...com>
Cc:	Richard Purdie <rpurdie@...ys.net>,
	"linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] leds-lp8788: fix a parent device in _probe()

On Wed, Jan 2, 2013 at 10:28 PM, Kim, Milo <Milo.Kim@...com> wrote:
>  The lp8788-keyled is a platform driver of lp8788-mfd.
>  The platform device is allocated when mfd_add_devices() is called
>  in lp8788-mfd.
>  On the other hand, 'lp->dev' is the i2c client device.
>
>  Therefore, this 'platform_device' is a proper parent device in case of
>  resource managed mem alloc, registering led device and device kernel messages.
>

Reasonable, I merged into my for-next branch.

Thanks,
-Bryan

> Signed-off-by: Milo(Woogyom) Kim <milo.kim@...com>
> ---
>  drivers/leds/leds-lp8788.c |    9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/leds/leds-lp8788.c b/drivers/leds/leds-lp8788.c
> index 4353942..7c2cb38 100644
> --- a/drivers/leds/leds-lp8788.c
> +++ b/drivers/leds/leds-lp8788.c
> @@ -130,9 +130,10 @@ static int lp8788_led_probe(struct platform_device *pdev)
>         struct lp8788 *lp = dev_get_drvdata(pdev->dev.parent);
>         struct lp8788_led_platform_data *led_pdata;
>         struct lp8788_led *led;
> +       struct device *dev = &pdev->dev;
>         int ret;
>
> -       led = devm_kzalloc(lp->dev, sizeof(struct lp8788_led), GFP_KERNEL);
> +       led = devm_kzalloc(dev, sizeof(struct lp8788_led), GFP_KERNEL);
>         if (!led)
>                 return -ENOMEM;
>
> @@ -154,13 +155,13 @@ static int lp8788_led_probe(struct platform_device *pdev)
>
>         ret = lp8788_led_init_device(led, led_pdata);
>         if (ret) {
> -               dev_err(lp->dev, "led init device err: %d\n", ret);
> +               dev_err(dev, "led init device err: %d\n", ret);
>                 return ret;
>         }
>
> -       ret = led_classdev_register(lp->dev, &led->led_dev);
> +       ret = led_classdev_register(dev, &led->led_dev);
>         if (ret) {
> -               dev_err(lp->dev, "led register err: %d\n", ret);
> +               dev_err(dev, "led register err: %d\n", ret);
>                 return ret;
>         }
>
> --
> 1.7.9.5
>
>
> Best Regards,
> Milo
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists