lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 03 Jan 2013 11:34:14 -0800
From:	Joe Perches <>
To:	Jacob Pan <>
Cc:	Linux PM <>,
	LKML <>,
	Rafael Wysocki <>,
	Len Brown <>,
	Thomas Gleixner <>,
	"H. Peter Anvin" <>, Ingo Molnar <>,
	Zhang Rui <>, Rob Landley <>,
	Arjan van de Ven <>,
	Paul McKenney <>,
	Peter Zijlstra <>
Subject: Re: [PATCH v4 3/3] PM: Introduce Intel PowerClamp Driver

On Thu, 2013-01-03 at 03:01 -0800, Jacob Pan wrote:
> Intel PowerClamp driver performs synchronized idle injection across
> all online CPUs. The goal is to maintain a given package level C-state
> ratio.

just trivia:

> diff --git a/drivers/thermal/intel_powerclamp.c b/drivers/thermal/intel_powerclamp.c

> +static int clamping;

bool and use true/false?

> +static int window_size_set(const char *arg, const struct kernel_param *kp)
> +	if (new_window_size >= 10 || new_window_size < 2) {
> +		pr_err("Invalid window size %lu, between 2-10\n",
> +			new_window_size);

This is a misleading message or a bad test,
It's from 2 to 9

This would more normally be tested/written as

	val < low || val > high

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists