linux-kernel - Re: uapi __NR_syscalls for microblaze

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201301032227.05553.arnd@arndb.de>
Date:	Thu, 3 Jan 2013 22:27:05 +0000
From:	Arnd Bergmann <arnd@...db.de>
To:	Michal Simek <monstr@...str.eu>
Cc:	David Howells <dhowells@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	linux-arch@...r.kernel.org
Subject: Re: uapi __NR_syscalls for microblaze

On Thursday 03 January 2013, Michal Simek wrote:
> 
> 2013/1/3 Arnd Bergmann <arnd@...db.de>:
> > On Thursday 03 January 2013, Michal Simek wrote:
> >> 2013/1/3 David Howells <dhowells@...hat.com>:
> >> > Michal Simek <monstr@...str.eu> wrote:
> >> >
> >> >> just want to check with you if __NR_syscalls is necessary for user space. I
> >> >> see that powerpc and arm have this macro in asm not in uapi like Microblaze.
> >> >> If is not needed by user space, I should move it to asm/unistd.h
> >> >
> >> > It isn't as far as I know...  I recommend putting your question on the
> >> > linux-arch mailing list.
> >>
> >> I have add linux-arch to CC.
> >
> > Right, I'm pretty sure it's not needed, but it has traditionally been
> > exported on a lot of platforms, so you can keep it in UAPI to be
> > on the safe side.
> 
> Isn't it better to be consistent across all architectures?

Yes, certainly.

> If it is wrong to exported and there is no reason to use it in userspace
> then all architecture should move it out of uapi.
> If there is any reason then it is should be in uapi.

I don't really care which way we do it, I think you can rightfully argue
either way. AFAICT x86 doesn't even define __NR_syscalls at all, so
it's clearly not part of the ABI.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/