[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <50E6158C.3050700@calxeda.com>
Date: Thu, 03 Jan 2013 17:34:36 -0600
From: Rob Herring <rob.herring@...xeda.com>
To: Pantelis Antoniou <panto@...oniou-consulting.com>
CC: Grant Likely <grant.likely@...retlab.ca>,
devicetree-discuss@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
Matt Porter <mporter@...com>, Russ Dill <Russ.Dill@...com>,
Jon Loeliger <jdl@....com>
Subject: Re: [PATCH] dtc: fdtdump, properly handle multi-string properties
On 01/03/2013 04:32 PM, Pantelis Antoniou wrote:
> Device tree can store multiple strings in a single property.
> We didn't handle that case properly.
>
> Signed-off-by: Pantelis Antoniou <panto@...oniou-consulting.com>
> ---
> scripts/dtc/fdtdump.c | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
These need to be posted against the upstream dtc sources and to the dtc
maintainer Jon Loeliger.
Rob
>
> diff --git a/scripts/dtc/fdtdump.c b/scripts/dtc/fdtdump.c
> index 207a46d..d4fa6d7 100644
> --- a/scripts/dtc/fdtdump.c
> +++ b/scripts/dtc/fdtdump.c
> @@ -21,13 +21,23 @@ static void print_data(const char *data, int len)
> {
> int i;
> const char *p = data;
> + const char *s;
>
> /* no data, don't print */
> if (len == 0)
> return;
>
> if (util_is_printable_string(data, len)) {
> - printf(" = \"%s\"", (const char *)data);
> + printf(" = ");
> +
> + s = data;
> + do {
> + printf("\"%s\"", s);
> + s += strlen(s) + 1;
> + if (s < data + len)
> + printf(", ");
> + } while (s < data + len);
> +
> } else if ((len % 4) == 0) {
> printf(" = <");
> for (i = 0; i < len; i += 4)
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists