lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20130103002533.5fb0c984@annuminas.surriel.com> Date: Thu, 3 Jan 2013 00:25:33 -0500 From: Rik van Riel <riel@...hat.com> To: Rik van Riel <riel@...hat.com> Cc: linux-kernel@...r.kernel.org, aquini@...hat.com, walken@...gle.com, eric.dumazet@...il.com, lwoodman@...hat.com, jeremy@...p.org, Jan Beulich <JBeulich@...ell.com>, Thomas Gleixner <tglx@...utronix.de>, knoel@...hat.com Subject: [RFC PATCH 5/5] x86,smp: add debugging code to track spinlock delay value From: Eric Dumazet <eric.dumazet@...il.com> This code prints out the maximum spinlock delay value and the backtrace that pushed it that far. On systems with serial consoles, the act of printing can cause the spinlock delay value to explode. It can still be useful as a debugging tool, but is probably too verbose to merge upstream in this form. Not-signed-off-by: Rik van Riel <riel@...hat.com> Not-signed-off-by: Eric Dumazet <eric.dumazet@...il.com> --- arch/x86/kernel/smp.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/arch/x86/kernel/smp.c b/arch/x86/kernel/smp.c index 29360c4..a4401ed 100644 --- a/arch/x86/kernel/smp.c +++ b/arch/x86/kernel/smp.c @@ -148,6 +148,8 @@ static DEFINE_PER_CPU(struct delay_entry [1 << DELAY_HASH_SHIFT], spinlock_delay }, }; +static DEFINE_PER_CPU(u16, maxdelay); + void ticket_spin_lock_wait(arch_spinlock_t *lock, struct __raw_tickets inc) { __ticket_t head = inc.head, ticket = inc.tail; @@ -195,6 +197,12 @@ void ticket_spin_lock_wait(arch_spinlock_t *lock, struct __raw_tickets inc) } ent->hash = hash; ent->delay = delay; + + if (__this_cpu_read(maxdelay) < delay) { + pr_err("cpu %d lock %p delay %d\n", smp_processor_id(), lock, delay); + __this_cpu_write(maxdelay, delay); + WARN_ON(1); + } } /* -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists