linux-kernel - Re: radeon 0000:02:00.0: GPU lockup CP stall for more than 10000msec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130104074054.GB20905@x1.alien8.de>
Date:	Fri, 4 Jan 2013 08:40:55 +0100
From:	Borislav Petkov <bp@...en8.de>
To:	Alex Deucher <alexdeucher@...il.com>
Cc:	Markus Trippelsdorf <markus@...ppelsdorf.de>,
	Jerome Glisse <j.glisse@...il.com>,
	Antti Palosaari <crope@....fi>,
	Shuah Khan <shuahkhan@...il.com>,
	Andy Furniss <andyqos@...sn.org>,
	Alex Deucher <alexander.deucher@....com>,
	dri-devel@...ts.freedesktop.org,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: radeon 0000:02:00.0: GPU lockup CP stall for more than 10000msec

On Wed, Jan 02, 2013 at 06:37:23PM -0500, Alex Deucher wrote:
> From: Alex Deucher <alexander.deucher@....com>
> Date: Wed, 2 Jan 2013 18:30:21 -0500
> Subject: [PATCH] drm/radeon/r6xx: fix DMA engine for ttm bo transfers
> 
> count must be a multiple of 2.
> 
> Cc: Borislav Petkov <bp@...en8.de>
> Cc: Markus Trippelsdorf <markus@...ppelsdorf.de>
> Signed-off-by: Alex Deucher <alexander.deucher@....com>

Thanks, will run it on the box in question next week when I have access.

Btw, you could add the note about count needing to be a multiple of 2 as
a comment in the code below, for future reference.

> ---
>  drivers/gpu/drm/radeon/r600.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/radeon/r600.c b/drivers/gpu/drm/radeon/r600.c
> index 2aaf147..9f4ce5e 100644
> --- a/drivers/gpu/drm/radeon/r600.c
> +++ b/drivers/gpu/drm/radeon/r600.c
> @@ -2636,8 +2636,8 @@ int r600_copy_dma(struct radeon_device *rdev,
>  
>  	for (i = 0; i < num_loops; i++) {
>  		cur_size_in_dw = size_in_dw;
> -		if (cur_size_in_dw > 0xFFFF)
> -			cur_size_in_dw = 0xFFFF;
> +		if (cur_size_in_dw > 0xFFFE)
> +			cur_size_in_dw = 0xFFFE;
>  		size_in_dw -= cur_size_in_dw;
>  		radeon_ring_write(ring, DMA_PACKET(DMA_PACKET_COPY, 0, 0, cur_size_in_dw));
>  		radeon_ring_write(ring, dst_offset & 0xfffffffc);
> -- 
> 1.7.7.5

-- 
Regards/Gruss,
Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/