linux-kernel - Re: [PATCH] sound: Add support for Creative BT-D1 via usb sound quirks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5htxqxp8yq.wl%tiwai@suse.de>
Date:	Fri, 04 Jan 2013 10:56:45 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Alexander Schremmer <alex@...xanderweb.de>
Cc:	Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sound: Add support for Creative BT-D1 via usb sound quirks

At Thu, 03 Jan 2013 12:59:07 +0100,
Alexander Schremmer wrote:
> 
> On 03.01.2013 10:58, Takashi Iwai wrote:
> 
> > Thanks for the patch.  The changes look OK, but could you fix trivial
> > coding issues reported by scripts/checkpatch.pl and resend?
> 
> Oops, my sending workflow ate the tabs, here it is again (hopefully now
> working correctly):
> 
> 
> From: Alexander Schremmer <alex@...xanderweb.de>
> 
> Support the Creative BT-D1 Bluetooth USB audio device. Before this
> patch, Linux had trouble finding the correct USB descriptors and bailed
> out with these messages:
> 
>  no or invalid class specific endpoint descriptor
> 
> Now it still prints these messages on hotplug:
> 
>  snd-usb-audio: probe of ...:1.0 failed with error -5
>  snd-usb-audio: probe of ...:1.2 failed with error -5
>  snd-usb-audio: probe of ...:1.3 failed with error -5
> 
> But the device works correctly, including the HID support.
> 
> The patch is diff'ed against 3.8-rc1 but should apply to older kernels
> as well.
> 
> Signed-off-by: Alexander Schremmer <alex@...xanderweb.de>

Thanks, applied.


Takashi

> 
> ---
> diff -uprN linux-3.8-rc1/sound/usb/quirks-table.h
> linux-3.8-rc1-mod/sound/usb/quirks-table.h
> --- linux-3.8-rc1/sound/usb/quirks-table.h	2012-12-22 02:19:00.000000000
> +0100
> +++ linux-3.8-rc1-mod/sound/usb/quirks-table.h	2012-12-26
> 11:41:28.000000000 +0100
> @@ -50,6 +50,28 @@
>  	}
>  },
> 
> +{
> +	/* Creative BT-D1 */
> +	USB_DEVICE(0x041e, 0x0005),
> +	.driver_info = (unsigned long) &(const struct snd_usb_audio_quirk) {
> +		.ifnum = 1,
> +		.type = QUIRK_AUDIO_FIXED_ENDPOINT,
> +		.data = &(const struct audioformat) {
> +			.formats = SNDRV_PCM_FMTBIT_S16_LE,
> +			.channels = 2,
> +			.iface = 1,
> +			.altsetting = 1,
> +			.altset_idx = 1,
> +			.endpoint = 0x03,
> +			.ep_attr = USB_ENDPOINT_XFER_ISOC,
> +			.attributes = 0,
> +			.rates = SNDRV_PCM_RATE_CONTINUOUS,
> +			.rate_min = 48000,
> +			.rate_max = 48000,
> +		}
> +	}
> +},
> +
>  /* Creative/Toshiba Multimedia Center SB-0500 */
>  {
>  	USB_DEVICE(0x041e, 0x3048),
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/