linux-kernel - Re: [PATCH 21/27] nohz: Only stop the tick on RCU nocb CPUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFTL4hz9uErzuHkWDPj-SzA83uh52gjUCmU+cNgq9gaRTrUHFg@mail.gmail.com>
Date:	Fri, 4 Jan 2013 13:53:19 +0100
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Alessio Igor Bogani <abogani@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Chris Metcalf <cmetcalf@...era.com>,
	Christoph Lameter <cl@...ux.com>,
	Geoff Levand <geoff@...radead.org>,
	Gilad Ben Yossef <gilad@...yossef.com>,
	Hakan Akkan <hakanakkan@...il.com>,
	Ingo Molnar <mingo@...nel.org>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 21/27] nohz: Only stop the tick on RCU nocb CPUs

2013/1/2 Namhyung Kim <namhyung@...nel.org>:
> You may want to add the following also to shut up the gcc:
>
>       CC      kernel/rcutree.o
>     In file included from /home/namhyung/project/linux/kernel/rcutree.c:58:0:
>     /home/namhyung/project/linux/kernel/rcutree.h:539:13: warning: ‘is_nocb_cpu’ declared ‘static’ but never defined [-Wunused-function]
>
>
> Thanks,
> Namhyung
>
>
> diff --git a/kernel/rcutree.h b/kernel/rcutree.h
> index 4b69291b093d..fbbad931c36a 100644
> --- a/kernel/rcutree.h
> +++ b/kernel/rcutree.h
> @@ -536,7 +536,6 @@ static void print_cpu_stall_info(struct rcu_state *rsp, int cpu);
>  static void print_cpu_stall_info_end(void);
>  static void zero_cpu_stall_ticks(struct rcu_data *rdp);
>  static void increment_cpu_stall_ticks(void);
> -static bool is_nocb_cpu(int cpu);
>  static bool __call_rcu_nocb(struct rcu_data *rdp, struct rcu_head *rhp,
>                             bool lazy);
>  static bool rcu_nocb_adopt_orphan_cbs(struct rcu_state *rsp,

I'm folding that fix for the next version.

Thanks Namhyung!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/