linux-kernel - Re: [PATCH 05/27] cputime: Safely read cputime of full dynticks CPUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFTL4hyB500N+W9R0DZQ_QfyHULfnceKqgNHwkEHtxqiBa87ww@mail.gmail.com>
Date:	Fri, 4 Jan 2013 14:42:11 +0100
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Li Zhong <zhong@...ux.vnet.ibm.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Alessio Igor Bogani <abogani@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Chris Metcalf <cmetcalf@...era.com>,
	Christoph Lameter <cl@...ux.com>,
	Geoff Levand <geoff@...radead.org>,
	Gilad Ben Yossef <gilad@...yossef.com>,
	Hakan Akkan <hakanakkan@...il.com>,
	Ingo Molnar <mingo@...nel.org>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 05/27] cputime: Safely read cputime of full dynticks CPUs

2012/12/31 Li Zhong <zhong@...ux.vnet.ibm.com>:
> On Sat, 2012-12-29 at 17:42 +0100, Frederic Weisbecker wrote:
>>  static inline void vtime_task_switch(struct task_struct *prev) { }
>>  static inline void vtime_account_system(struct task_struct *tsk) { }
>>  static inline void vtime_account_system_irqsafe(struct task_struct *tsk) { }
>>  static inline void vtime_account_user(struct task_struct *tsk) { }
>> -static inline void vtime_account(struct task_struct *tsk) { }
>> +static inline void vtime_account_irq_enter(struct task_struct *tsk) { }
>>  static inline bool vtime_accounting(void) { return false; }
>>  #endif
>>
>>  #ifdef CONFIG_VIRT_CPU_ACCOUNTING_GEN
>> -static inline void arch_vtime_task_switch(struct task_struct *tsk) { }
>> +extern void arch_vtime_task_switch(struct task_struct *tsk);
>> +extern void vtime_account_irq_exit(struct task_struct *tsk);
>> +extern void vtime_user_enter(struct task_struct *tsk);
>> +extern bool vtime_accounting(void);
>> +#else
>> +static inline void vtime_account_irq_exit(struct task_struct *tsk)
>> +{
>> +     /* On hard|softirq exit we always account to hard|softirq cputime */
>> +     vtime_account_system(tsk);
>> +}
>> +static inline void vtime_enter_user(struct task_struct *tsk) { }
>
> I guess the function name above should be "vtime_user_enter" to match
> the above extern, and the usage in user_enter()?

Totally! Thanks for pointing this out.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/