linux-kernel - Re: [PATCH] dmaengine: imx-dma: Disable use of hw_chain to fix sg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKLOr1NXVM3kUFkSMVf=BK9g4EzwXbj2-gvxKjfThe4kAcTsg@mail.gmail.com>
Date:	Fri, 4 Jan 2013 16:37:44 +0100
From:	javier Martin <javier.martin@...ta-silicon.com>
To:	linux-kernel@...r.kernel.org
Cc:	djbw@...com, vinod.koul@...el.com,
	Javier Martin <javier.martin@...ta-silicon.com>
Subject: Re: [PATCH] dmaengine: imx-dma: Disable use of hw_chain to fix sg_dma transfers.

On 30 October 2012 16:58, Javier Martin <javier.martin@...ta-silicon.com> wrote:
> HW chaining is currently broken in imx-dma. It can be easily reproduced doing
> intensive accesses to a external MMC card and checking how the file system
> is corrupted.
>
> Preventing the driver to use HW chaining solves these issues.
>
>
> Signed-off-by: Javier Martin <javier.martin@...ta-silicon.com>
> ---
>  drivers/dma/imx-dma.c |    5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/dma/imx-dma.c b/drivers/dma/imx-dma.c
> index 5084975..03f3b64 100644
> --- a/drivers/dma/imx-dma.c
> +++ b/drivers/dma/imx-dma.c
> @@ -643,9 +643,8 @@ static int imxdma_control(struct dma_chan *chan, enum dma_ctrl_cmd cmd,
>                         break;
>                 }
>
> -               imxdmac->hw_chaining = 1;
> -               if (!imxdma_hw_chain(imxdmac))
> -                       return -EINVAL;
> +               imxdmac->hw_chaining = 0;
> +
>                 imxdmac->ccr_from_device = (mode | IMX_DMA_TYPE_FIFO) |
>                         ((IMX_DMA_MEMSIZE_32 | IMX_DMA_TYPE_LINEAR) << 2) |
>                         CCR_REN;
> --
> 1.7.9.5
>

Hi Vinod,
I see you missed this patch for 3.7. Could you please apply it as a fix for 3.8?

Regards.

-- 
Javier Martin
Vista Silicon S.L.
CDTUC - FASE C - Oficina S-345
Avda de los Castros s/n
39005- Santander. Cantabria. Spain
+34 942 25 32 60
www.vista-silicon.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/