[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <50E7330D.2060107@wwwdotorg.org>
Date: Fri, 04 Jan 2013 12:52:45 -0700
From: Stephen Warren <swarren@...dotorg.org>
To: Laxman Dewangan <ldewangan@...dia.com>
CC: dmitry.torokhov@...il.com, grant.likely@...retlab.ca,
rob.herring@...xeda.com, swarren@...dia.com,
devicetree-discuss@...ts.ozlabs.org, linux-doc@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
linux-tegra@...r.kernel.org
Subject: Re: [PATCH 4/4] input: keyboard: tegra: remove default key mapping
On 01/04/2013 04:02 AM, Laxman Dewangan wrote:
> Tegra KBC driver have the default key mapping for 16x8 configuration.
> The key mapping can be provided through platform data or through DT
> and the mapping varies from platform to platform, hence this default
> mapping is not so useful. Remove the default mapping to reduce the code
> lines of the driver.
Overall, I agree with the intent of this change, but I /think/ the
default keymap described here actually /is/ useful for the
Seaboard/Springbank platforms. I guess the KBC driver isn't in the
device tree for that (or any) board yet, so removing this keymap isn't
really a regression, but it would be nice if you could come up with a
change to add suitable keymaps to the device tree files too.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists