linux-kernel - Re: [PATCH v7u1 06/31] x86, 64bit, realmode: use init_level4_pgt to set trapmoline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1357379977.20394.7.camel@jsakkine-mobl1>
Date:	Sat, 5 Jan 2013 09:59:02 +0000
From:	"Sakkinen, Jarkko" <jarkko.sakkinen@...el.com>
To:	Yinghai Lu <yinghai@...nel.org>
CC:	Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...e.hu>,
	"H. Peter Anvin" <hpa@...or.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Borislav Petkov <bp@...en8.de>, Jan Kiszka <jan.kiszka@....de>,
	Jason Wessel <jason.wessel@...driver.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v7u1 06/31] x86, 64bit, realmode: use init_level4_pgt to
 set trapmoline_pgt directly

On Fri, 2013-01-04 at 14:01 -0800, Yinghai Lu wrote:
> On Fri, Jan 4, 2013 at 9:18 AM, Sakkinen, Jarkko
> <jarkko.sakkinen@...el.com> wrote:
> > On Thu, 2013-01-03 at 16:48 -0800, Yinghai Lu wrote:
> >> with #PF handler way to set early page table, level3_ident will go away with
> >> 64bit native path.
> >>
> >> So just use entries in init_level4_pgt to set them in tramopline_pgt
> >>
> >> Signed-off-by: Yinghai Lu <yinghai@...nel.org>
> >> Cc: Jarkko Sakkinen <jarkko.sakkinen@...el.com>
> >
> > Acked-by: Jarkko Sakkinen <jarkko.sakkinen@...el.com>
> 
> Thanks.
> 
> updated the patch, and would save some time for HPA.

Sure. They look fine to me. Larger patch does only code
reordering from realmode code point of view and smaller 
patch initializes trampoline_gdt essentially with the 
same values as before so I don't see why these patches 
would break anything.

But let's wait for hpa comments.

/Jarkko