linux-kernel - Re: Linux 3.8-rc2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130106205511.GR5737@phenom.ffwll.local>
Date:	Sun, 6 Jan 2013 21:55:11 +0100
From:	Daniel Vetter <daniel@...ll.ch>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Alexey Zaytsev <alexey.zaytsev@...il.com>,
	Chris Wilson <chris@...is-wilson.co.uk>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Daniel Vetter <daniel.vetter@...ll.ch>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Rodrigo Vivi <rodrigo.vivi@...il.com>,
	Peter Ujfalusi <peter.ujfalusi@...il.com>,
	stable <stable@...r.kernel.org>
Subject: Re: Linux 3.8-rc2

On Thu, Jan 03, 2013 at 03:18:54PM -0800, Linus Torvalds wrote:
> On Thu, Jan 3, 2013 at 3:12 PM, Alexey Zaytsev <alexey.zaytsev@...il.com> wrote:
> >
> > Chris: The patch does not seem to have any effect on the problem.
> >
> > Peter: I've attached the dmesgs, as well as the diff between the
> > interesting parts. The patch does not seem to make any difference
> > there.
> 
> Alexey, what happens if you just avoid the divide-by-zero? There might
> be other complications downstream, but something like the attached
> patch should at least avoid doing the "divide-by-clock" when clock is
> zero..

Yeah, that looks like the better duct-tape. For context, we're in the
middle of the long road to fastboot, i.e. taking over the output setup
done by the bios to avoid a costly modeset at boot-up (at least for
somewhat sane firmware which doesn't use legacy vga mode any more but the
native resolution of the panel). But since we don't yet read out the full
hw state some assumptions are now broken in our code, so we need to catch
them.

Chris has a more complete patch covering all the other
generations/code-paths accessing crtc->mode.clock (but lost you from cc).
I'll forward his patch asap (still digging through the mail flood from
vacation).

Cheers, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/