linux-kernel - Re: [PATCH] bq2415x_charger: Remove unneeded version.h include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 6 Jan 2013 13:27:54 -0800
From:	Anton Vorontsov <anton@...msg.org>
To:	Jesper Juhl <jj@...osbits.net>
Cc:	linux-kernel@...r.kernel.org,
	David Woodhouse <dwmw2@...radead.org>,
	Pali Rohár <pali.rohar@...il.com>,
	trivial@...nel.org
Subject: Re: [PATCH] bq2415x_charger: Remove unneeded version.h include

On Tue, Dec 18, 2012 at 11:07:06PM +0100, Jesper Juhl wrote:
> The file uses nothing from the header, so including it is pointless.
> 
> Signed-off-by: Jesper Juhl <jj@...osbits.net>

Sachin Kamat sent a similar cleanup in Nov, so he wins. :)

> ---
>  drivers/power/bq2415x_charger.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/power/bq2415x_charger.c b/drivers/power/bq2415x_charger.c
> index ee842b3..2d1b568 100644
> --- a/drivers/power/bq2415x_charger.c
> +++ b/drivers/power/bq2415x_charger.c
> @@ -28,7 +28,6 @@
>   * http://www.ti.com/product/bq24155
>   */
>  
> -#include <linux/version.h>
>  #include <linux/kernel.h>
>  #include <linux/module.h>
>  #include <linux/param.h>
> -- 
> 1.7.1
> 
> 
> -- 
> Jesper Juhl <jj@...osbits.net>       http://www.chaosbits.net/
> Don't top-post http://www.catb.org/jargon/html/T/top-post.html
> Plain text mails only, please.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/