linux-kernel - Re: [PATCH 1/2] signals: sys_ssetmask() uses uninitialized newmask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1020130360.779.1357442883266.JavaMail.root@redhat.com>
Date:	Sat, 5 Jan 2013 22:28:03 -0500 (EST)
From:	CAI Qian <caiqian@...hat.com>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Linda Wang <lwang@...hat.com>, Matt Zywusko <mzywusko@...hat.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 1/2] signals: sys_ssetmask() uses uninitialized newmask



----- Original Message -----
> From: "Oleg Nesterov" <oleg@...hat.com>
> To: "CAI Qian" <caiqian@...hat.com>, "Andrew Morton" <akpm@...ux-foundation.org>, "Linus Torvalds"
> <torvalds@...ux-foundation.org>
> Cc: "Linda Wang" <lwang@...hat.com>, "Matt Zywusko" <mzywusko@...hat.com>, "Al Viro" <viro@...iv.linux.org.uk>,
> linux-kernel@...r.kernel.org
> Sent: Sunday, January 6, 2013 2:13:13 AM
> Subject: [PATCH 1/2] signals: sys_ssetmask() uses uninitialized newmask
> 
> 77097ae5 "most of set_current_blocked() callers want SIGKILL/SIGSTOP
> removed from set" removed the initialization of newmask by accident,
> restore.
> 
> Reported-by: CAI Qian <caiqian@...hat.com>
> Signed-off-by: Oleg Nesterov <oleg@...hat.com>
> Cc: stable@...nel.org	# v3.5+
Thanks Oleg. This is now passing the testing.

Tested-by: CAI Qian <caiqian@...hat.com>
> ---
>  kernel/signal.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/kernel/signal.c b/kernel/signal.c
> index 7aaa51d..9692499 100644
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -3286,6 +3286,7 @@ SYSCALL_DEFINE1(ssetmask, int, newmask)
>  	int old = current->blocked.sig[0];
>  	sigset_t newset;
>  
> +	siginitset(&newset, newmask);
>  	set_current_blocked(&newset);
>  
>  	return old;
> --
> 1.5.5.1
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/