linux-kernel - Re: [PATCH] [media] coda: Fix build due to iram.h rename

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOMZO5Cpa2OYd+v=wE4hbw=sjmQk+bP1HrY49PEWmwRyiVD1dg@mail.gmail.com>
Date:	Mon, 7 Jan 2013 08:16:02 -0200
From:	Fabio Estevam <festevam@...il.com>
To:	Sascha Hauer <s.hauer@...gutronix.de>
Cc:	linux-media@...r.kernel.org, mchehab@...radead.org,
	kernel@...gutronix.de, linux-kernel@...r.kernel.org,
	Fabio Estevam <fabio.estevam@...escale.com>
Subject: Re: [PATCH] [media] coda: Fix build due to iram.h rename

Hi Sascha,

On Mon, Jan 7, 2013 at 8:03 AM, Sascha Hauer <s.hauer@...gutronix.de> wrote:
> commit c045e3f13 (ARM: imx: include iram.h rather than mach/iram.h) changed the
> location of iram.h, which causes the following build error when building the coda
> driver:
>
> drivers/media/platform/coda.c:27:23: error: mach/iram.h: No such file or directory
> drivers/media/platform/coda.c: In function 'coda_probe':
> drivers/media/platform/coda.c:2000: error: implicit declaration of function 'iram_alloc'
> drivers/media/platform/coda.c:2001: warning: assignment makes pointer from integer without a cast
> drivers/media/platform/coda.c: In function 'coda_remove':
> drivers/media/platform/coda.c:2024: error: implicit declaration of function 'iram_free'
>
> Since the content of iram.h is not imx specific, move it to
> include/linux/platform_data/imx-iram.h instead. This is an intermediate solution
> until the i.MX iram allocator is converted to the generic SRAM allocator.
>
> Signed-off-by: Sascha Hauer <s.hauer@...gutronix.de>
> ---
>
> Based on an earlier version from Fabio Estevam, but this one moves iram.h
> to include/linux/platform_data/imx-iram.h instead of include/linux/iram.h
> which is a less generic name.
>
>  arch/arm/mach-imx/iram.h               |   41 --------------------------------
>  arch/arm/mach-imx/iram_alloc.c         |    3 +--
>  drivers/media/platform/coda.c          |    2 +-
>  include/linux/platform_data/imx-iram.h |   41 ++++++++++++++++++++++++++++++++
>  4 files changed, 43 insertions(+), 44 deletions(-)
>  delete mode 100644 arch/arm/mach-imx/iram.h
>  create mode 100644 include/linux/platform_data/imx-iram.h

It would be better to use git mv /git format-patch -M, so that git can
detect the file rename.

Regards,

Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/