linux-kernel - Re: [PATCH v2 43/44] tty/metag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130107115425.7a1c9176@pyramind.ukuu.org.uk>
Date:	Mon, 7 Jan 2013 11:54:25 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	James Hogan <james.hogan@...tec.com>
Cc:	<linux-arch@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	"Arnd Bergmann" <arnd@...db.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v2 43/44] tty/metag_da: Add metag DA TTY driver

> Yes. The case I tried was a large write (strace cat /etc/somefile >
> /dev/ttyDA2) and strace showed a single large write, but it got to the
> driver in chunks of a dozen or so characters. Is that expected to happen?

Yes it is - the tty mid layer code could do better on this but it's never
been much of a priority.

> @@ -613,8 +613,7 @@ static int __init dashtty_init(void)
>  	channel_driver->type = TTY_DRIVER_TYPE_SERIAL;
>  	channel_driver->subtype = SERIAL_TYPE_NORMAL;
>  	channel_driver->init_termios = tty_std_termios;
> -	channel_driver->init_termios.c_cflag =
> -	    B38400 | CS8 | CREAD | HUPCL | CLOCAL;
> +	channel_driver->init_termios.c_cflag |= CLOCAL;
>  	channel_driver->flags = TTY_DRIVER_REAL_RAW;
> 
>  	tty_set_operations(channel_driver, &dashtty_ops);


Ok
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/