linux-kernel - Re: [PATCH] dma: tegra: implement flags parameters for cyclic transfer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <50EAD307.9040604@nvidia.com>
Date:	Mon, 7 Jan 2013 19:22:07 +0530
From:	Laxman Dewangan <ldewangan@...dia.com>
To:	Stephen Warren <swarren@...dotorg.org>
CC:	"vinod.koul@...el.com" <vinod.koul@...el.com>,
	"djbw@...com" <djbw@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Stephen Warren <swarren@...dia.com>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH] dma: tegra: implement flags parameters for cyclic transfer

On Saturday 22 December 2012 02:23 AM, Stephen Warren wrote:
> On 12/20/2012 09:23 PM, Laxman Dewangan wrote:
>> On Thursday 20 December 2012 10:16 PM, Stephen Warren wrote:
>>> On 12/19/2012 11:11 PM, Laxman Dewangan wrote:
>>>> On Wednesday 19 December 2012 10:32 PM, Stephen Warren wrote:
>>>>> On 12/19/2012 06:40 AM, Laxman Dewangan wrote:
>>>>>> The flag parameter is added in the cyclic transfer request.
>>>>>> Use the flag option of:
>>>>>> - DMA_PREP_INTERRUPT for enabling interrupt.
>>>>>> - DMA_CTRL_ACK for deciding whether ack is requred or not for
>>>>>>      descriptor.
>>>>> Do the relevant drivers that use Tegra's DMA engine already set flags
>>>>> correctly, so that this change won't cause any regressions?
>>>> Currently, the sound soc driver uses the cyclic mode of dma transfer and
>>>> it has already enable the proper flags. This was done recently after
>>>> adding flags in cyclic api.
>>>> Also, there was bug in our dma driver for not setting DMA_CTRL_ACK by
>>>> default for cyclic case.
>>>> This will fix the issue.
>>> OK. I assume "This was done recently after adding flags in cyclic api."
>>> was a patch that went into 3.8?  So, this patch is a bug-fix that should
>>> be included in 3.8 then?
>> I can see this in Linux 3.7 tag.
> So I assume that means that when Vinod applies *this* patch, it should
> be Cc: stable for 3.7 and up?
>
>> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=history;f=drivers/dma/tegra20-apb-dma.c;h=528c62dd4b00e1b52928ff66f3a54e7ae206680f;hb=29594404d7fe73cd80eaa4ee8c43dcc53970c60e
> I don't think that points where you want; it just shows a log of 3.7 for me.

Oops, I just wanted to say that 3.7 branch and history of 
drivers/dma/tegra20-apb-dma.c shows the above change of inclusion of flags.
Seems link is messed up.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/