linux-kernel - Re: [PATCH 44/49] mm: numa: Add THP migration for the NUMA working set scanning fault case.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20130107153723.GN3885@suse.de>
Date:	Mon, 7 Jan 2013 15:37:23 +0000
From:	Mel Gorman <mgorman@...e.de>
To:	Wanpeng Li <liwanp@...ux.vnet.ibm.com>
Cc:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Andrea Arcangeli <aarcange@...hat.com>,
	Ingo Molnar <mingo@...nel.org>, Rik van Riel <riel@...hat.com>,
	Johannes Weiner <hannes@...xchg.org>,
	Hugh Dickins <hughd@...gle.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Paul Turner <pjt@...gle.com>, Hillf Danton <dhillf@...il.com>,
	David Rientjes <rientjes@...gle.com>,
	Lee Schermerhorn <Lee.Schermerhorn@...com>,
	Alex Shi <lkml.alex@...il.com>,
	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>,
	Aneesh Kumar <aneesh.kumar@...ux.vnet.ibm.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux-MM <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 44/49] mm: numa: Add THP migration for the NUMA working
 set scanning fault case.

On Sat, Jan 05, 2013 at 04:42:29PM +0800, Wanpeng Li wrote:
> >+int numamigrate_isolate_page(pg_data_t *pgdat, struct page *page)
> >+{
> >+	int ret = 0;
> >
> > 	/* Avoid migrating to a node that is nearly full */
> > 	if (migrate_balanced_pgdat(pgdat, 1)) {
> 
> Hi Mel Gorman,
> 
> This parameter nr_migrate_pags = 1 is not correct, since balancenuma also 
> support THP in this patchset, the parameter should be 1 <= compound_order(page) 
> instead of 1. I'd rather change to something like:
> 

True. The impact is marginal because it only applies when a node is almost
full but it does mean that we do some unnecessary work before migration
fails anyway. I've added a TODO item to fix it when I next revisit NUMA
balancing. Thanks.

-- 
Mel Gorman
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/