linux-kernel - Re: [PATCH] asm-generic/io.h: convert readX defines to functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12944963.pK1utZClTO@wuerfel>
Date:	Mon, 07 Jan 2013 15:42:38 +0000
From:	Arnd Bergmann <arnd@...db.de>
To:	Heiko Carstens <heiko.carstens@...ibm.com>
Cc:	Gerald Schaefer <geraldsc@...ibm.com>,
	Sebastian Ott <sebott@...ux.vnet.ibm.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] asm-generic/io.h: convert readX defines to functions

On Monday 07 January 2013 16:34:59 Heiko Carstens wrote:
> 
> E.g. readl is defined like this
> 
>  #define readl(addr) __le32_to_cpu(__raw_readl(addr))
> 
> If there is a readl() call that doesn't check the return value
> this will cause a compile warning on big endian machines due to
> the __le32_to_cpu macro magic.
> 
> E.g. code like this:
> 
>         readl(addr);
> 
> will generate the following compile warning:
> 
> warning: value computed is not used [-Wunused-value]
> 
> Convert the defines to functions so we get rid of these warnings.
> With this patch we get rid of dozens of compile warnings on s390.
> 
> Signed-off-by: Heiko Carstens <heiko.carstens@...ibm.com>

Acked-by: Arnd Bergmann <arnd@...db.de>

if you fix this:

> +#define readl readl
> +static inline u32 __raw_readl(const volatile void __iomem *addr)
> +{
> +       return __le32_to_cpu(__raw_readl(addr));
> +}
 
to be called readl rather than __raw_readl

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/