linux-kernel - Re: [PATCH 04/32] aio: remove retry-based AIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130107221219.GC26407@google.com>
Date:	Mon, 7 Jan 2013 14:12:19 -0800
From:	Kent Overstreet <koverstreet@...gle.com>
To:	Hillf Danton <dhillf@...il.com>
Cc:	linux-kernel@...r.kernel.org, linux-aio@...ck.org,
	linux-fsdevel@...r.kernel.org, Zach Brown <zab@...hat.com>,
	bcrl@...ck.org, jmoyer@...hat.com, axboe@...nel.dk,
	viro@...iv.linux.org.uk, tytso@....edu
Subject: Re: [PATCH 04/32] aio: remove retry-based AIO

On Sat, Dec 29, 2012 at 03:36:38PM +0800, Hillf Danton wrote:
> On Thu, Dec 27, 2012 at 9:59 AM, Kent Overstreet <koverstreet@...gle.com> wrote:
> > -       /*
> > -        * This is so that aio_complete knows it doesn't need to
> > -        * pull the iocb off the run list (We can't just call
> > -        * INIT_LIST_HEAD because we don't want a kick_iocb to
> > -        * queue this on the run list yet)
> > -        */
> > -       iocb->ki_run_list.next = iocb->ki_run_list.prev = NULL;
> 
> The tricky, list.next = NULL, is erased here, but it is reused in one of
> the subsequent patches, why?

I think you're confusing the two different linked lists - there's
ki_run_list, which isn't used anymore after this patch (and deleted
here), and ki_list, which is used for cancellation.

Yeah, it's tricky and ugly.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/