[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1357624142-7178-1-git-send-email-harvey.huawei.yang@gmail.com>
Date: Tue, 8 Jan 2013 13:49:00 +0800
From: Harvey Yang <harvey.huawei.yang@...il.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Matt Mooney <mfm@...eddisk.com>, linux-usb@...r.kernel.org
Cc: linux-kernel@...r.kernel.org,
Harvey Yang <harvey.huawei.yang@...il.com>
Subject: [PATCH 0/2] staging: usbip: refine the lock
This patchset refines some spinlocks which maybe not used properly.
[PATCH 1/2]: The function 'usbip_event_add()' may be called in interrupt context on the stub side:
'stub_complete'->'stub_enqueue_ret_unlink'->'usbip_event_add'.
In this function it tries to get the lock 'ud->lock', so we should disable irq when we get this lock in process context.
[PATCH 2/2]: On the client side, we have a virtual hcd driver, there actually no hardware interrupts, so we do not need worry about race conditions caused by irq. To achieve a good performance there is no need to use the interrupt safe spinlock. Just replace them with a non interrupt safe version.
Harvey Yang (2):
staging: usbip: use interrupt safe spinlock to avoid potential
deadlock.
staging: usbip: replace the interrupt safe spinlocks with common
ones.
drivers/staging/usbip/stub_dev.c | 34 ++++++++--------
drivers/staging/usbip/stub_rx.c | 4 +-
drivers/staging/usbip/usbip_event.c | 6 ++-
drivers/staging/usbip/vhci_hcd.c | 76 +++++++++++++++--------------------
drivers/staging/usbip/vhci_rx.c | 10 ++---
drivers/staging/usbip/vhci_tx.c | 14 +++----
6 files changed, 65 insertions(+), 79 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists