linux-kernel - Re: [PATCH] Added NIST CMAC to the CryptoAPI library

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130108085425.GU18940@secunet.com>
Date:	Tue, 8 Jan 2013 09:54:25 +0100
From:	Steffen Klassert <steffen.klassert@...unet.com>
To:	Tom St Denis <tstdenis@...iptictech.com>
Cc:	linux-kernel@...r.kernel.org, davem@...emloft.net,
	herbert@...dor.apana.org.au
Subject: Re: [PATCH]  Added NIST CMAC to the CryptoAPI library

On Tue, Dec 11, 2012 at 02:00:10PM -0500, Tom St Denis wrote:
> This patch adds NIST CMAC cipher based MAC as described in FIPS 800-38B to
> the CryptoAPI stack.  It also wires up the MAC to the IPsec stack as per
> RFC 4494.
> 
> This patch was tested against 3.7 with third party hardware IPsec.
> 
> Signed-off-by: Tom St Denis <tstdenis@...iptictech.com>
> Acked-by: David S. Miller <davem@...emloft.net>
> 

I agreed with Herbert Xu to integrate this via the ipsec-next tree.

However, it introduces the following warning:

crypto/cmac.c: In function ‘crypto_cmac_digest_setkey’:
crypto/cmac.c:97:4: warning: suggest parentheses around arithmetic in
operand of ‘^’ [-Wparentheses]

It also has a lot of coding style issues, run checkpatch.

Please fix it and resend.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/