linux-kernel - Re: Fix test relying in wrong behavior of is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130108083734.GA9055@truffula.fritz.box>
Date:	Tue, 8 Jan 2013 19:37:34 +1100
From:	David Gibson <david@...son.dropbear.id.au>
To:	Pantelis Antoniou <panto@...oniou-consulting.com>
Cc:	Jon Loeliger <jdl@....com>, Matt Porter <mporter@...com>,
	"devicetree-discuss@...ts.ozlabs.org" 
	<devicetree-discuss@...ts.ozlabs.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Rob Herring <rob.herring@...xeda.com>,
	Russ Dill <Russ.Dill@...com>
Subject: Re: Fix test relying in wrong behavior of is_printable

On Sun, Jan 06, 2013 at 01:41:56PM +0200, Pantelis Antoniou wrote:
> Hi David
> 
> Από το iPhone μου
> 
> 6 Ιαν 2013, 5:58, ο/η David Gibson <david@...son.dropbear.id.au> έγραψε:
> 
> > On Fri, Jan 04, 2013 at 09:16:08PM +0200, Pantelis Antoniou wrote:
> >> After fixing the is_printable bug the test suite fails.
> >> Fix it with this patch
> >> 
> >> Signed-off-by: Pantelis Antoniou <panto@...oniou-consulting.com>
> > 
> > Rather than just removing the test, it would be better to still run it
> > using an explicit -t bi to force the byte output.
> 
> Perhaps it wasn't exactly clear in the patch. The old test case
> output is commented out but there is test case output for the new
> patch.

I realise that, but that's not my point.  Rather than replacing the
test for the old behaviour with the new one, I'd prefer to keep the
one checking the old behaviour, forcing that behaviour from fdtget
using -t bi

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)