linux-kernel - Re: [PATCH 02/25] ab8500_charger: don't use [delayed_]work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYeHP6DCDH5XO8EyqAUaQWczqffGKaMEMXXDPVSAE_DWQ@mail.gmail.com>
Date:	Tue, 8 Jan 2013 15:30:23 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Tejun Heo <tj@...nel.org>
Cc:	linux-kernel@...r.kernel.org,
	Srinidhi Kasagar <srinidhi.kasagar@...ricsson.com>,
	Marcus COOPER <marcus.xm.cooper@...ricsson.com>
Subject: Re: [PATCH 02/25] ab8500_charger: don't use [delayed_]work_pending()

On Sat, Dec 22, 2012 at 2:56 AM, Tejun Heo <tj@...nel.org> wrote:

> There's no need to test whether a (delayed) work item in pending
> before queueing, flushing or cancelling it.  Most uses are unnecessary
> and quite a few of them are buggy.
>
> Remove unnecessary pending tests from ab8500_charger.  Only compile
> tested.
>
> Signed-off-by: Tejun Heo <tj@...nel.org>
> Cc: Srinidhi Kasagar <srinidhi.kasagar@...ricsson.com>
> Cc: Linus Walleij <linus.walleij@...aro.org>

Works like a charm for us, thanks!
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
Tested-by: Marcus Cooper <marcus.xm.cooper@...ricsson.com>

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/