linux-kernel - Antw: [PATCH 0/5] kfifo cleanup and log based kfifo API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <50EC4345020000A10000E5D1@gwsmtp1.uni-regensburg.de>
Date:	Tue, 08 Jan 2013 16:03:17 +0100
From:	"Ulrich Windl" <Ulrich.Windl@...uni-regensburg.de>
To:	"Yuanhan Liu" <yuanhan.liu@...ux.intel.com>,
	<linux-kernel@...r.kernel.org>
Cc:	"Mike Christie" <michaelc@...wisc.edu>,
	"iscsi list" <open-iscsi@...glegroups.com>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"James E.J. Bottomley" <JBottomley@...allels.com>,
	"Stefani Seibold" <stefani@...bold.net>
Subject: Antw: [PATCH 0/5] kfifo cleanup and log based kfifo API

>>> Yuanhan Liu <yuanhan.liu@...ux.intel.com> schrieb am 08.01.2013 um 15:57 in
Nachricht <1357657073-27352-1-git-send-email-yuanhan.liu@...ux.intel.com>:

[...]
> My proposal is to replace kfifo_init with kfifo_alloc, where it
> allocate buffer and maintain fifo size inside kfifo. Then we can
> remove buggy kfifo_init.
[...]

Spontaneously I feel that emitting a critical message if the requested size is not a power of two would be a good idea, as well as (in that case) rounding up to the next power of two instead of rounding down seems not too stupid ;-)

Sorry, I'm not deeply into recent kernel development.

Regards,
Ulrich


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/