lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 8 Jan 2013 15:25:55 +0000 From: Russell King - ARM Linux <linux@....linux.org.uk> To: Boris BREZILLON <linux-arm@...rkiz.com> Cc: Thierry Reding <thierry.reding@...onic-design.de>, Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>, Nicolas Ferre <nicolas.ferre@...el.com>, Andrew Victor <linux@...im.org.za>, linux-kernel@...r.kernel.org, Haavard Skinnemoen <hskinnemoen@...il.com>, Hans-Christian Egtvedt <egtvedt@...fundet.no> Subject: Re: [PATCH v4 RESEND] pwm: atmel: add Timer Counter Block PWM driver On Tue, Jan 08, 2013 at 04:21:59PM +0100, Boris BREZILLON wrote: > Do I have to break the error string so that the line does not exceed 80 > characters ? No. > Checkpath script does not complain about it, and the CodingStyle file > specify that visible strings should not be broken... Correct. > Same question applies to this error, which I converted to a multi-line > error in a previous patch version: > > dev_err(chip->dev, > "failed to configure period_ns:\n" > "the other PWM device in this group is already\n" > "configured with a different period_ns value\n"); Which is a bad idea. It appears in log files as multiple lines, which makes parsing the error for analysis difficult (eg, you may have a log analyser which tells you how many times an error occurs - the above would be treated as three separate errors. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists