linux-kernel - Re: [PATCH 2/2] cgroups: fix cgroup_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130108180828.GA3926@htj.dyndns.org>
Date:	Tue, 8 Jan 2013 10:08:28 -0800
From:	Tejun Heo <tj@...nel.org>
To:	Li Zefan <lizefan@...wei.com>
Cc:	Greg Thelen <gthelen@...gle.com>,
	containers@...ts.linux-foundation.org, cgroups@...r.kernel.org,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] cgroups: fix cgroup_event_listener error handling

On Tue, Jan 08, 2013 at 02:28:44PM +0800, Li Zefan wrote:
> > cgroups: fix cgroup_event_listener error handling
> > 
> > The error handling in cgroup_event_listener.c did not correctly deal
> > with either an error opening either <control_file> or
> > cgroup.event_control.  Due to an uninitialized variable the program
> > exit code was undefined if either of these opens failed.
> > 
> > This patch simplifies and corrects cgroup_event_listener.c error
> > handling by:
> > 1. using err*() rather than printf(),exit()
> > 2. depending on process exit to close open files
> > 
> > With this patch failures always return non-zero error.
> > 
> > Signed-off-by: Greg Thelen <gthelen@...gle.com>
> 
> Acked-by: Li Zefan <lizefan@...wei.com>

Applied to cgroup/for-3.9.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/