linux-kernel - Re: [PATCH v5 00/12] x86/microcode: Early load microcode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50EC7E95.1060700@zytor.com>
Date:	Tue, 08 Jan 2013 12:16:21 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Konrad Rzeszutek Wilk <konrad@...nel.org>
CC:	Fenghua Yu <fenghua.yu@...el.com>, Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	Asit K Mallick <asit.k.mallick@...el.com>,
	Tigran Aivazian <tigran@...azian.fsnet.co.uk>,
	Yinghai Lu <yinghai@...nel.org>,
	Andreas Herrmann <andreas.herrmann3@....com>,
	Borislav Petkov <borislav.petkov@....com>,
	linux-kernel <linux-kernel@...r.kernel.org>, x86 <x86@...nel.org>
Subject: Re: [PATCH v5 00/12] x86/microcode: Early load microcode

On 01/08/2013 12:04 PM, Konrad Rzeszutek Wilk wrote:
>>
>> Why is this code invoked on Xen at all?  That seems crazy.
> 
>  [PATCH v4 09/11] x86/head64.c: Early update ucode in 64-bit
> 
> has this in x86_64_start_kernel:
> 
> ..
>         load_idt((const struct desc_ptr *)&idt_descr);
> 
> +       /*
> +        * Load microcode early on BSP.
> +        */
> +       load_ucode_bsp(__va(real_mode_data));
> +
>         copy_bootdata(__va(real_mode_data));
> 
> Which gets called after xen_start_kernel has setup pagetables,
> bootparams, etc ready for the generic code to be invoked.
> 
> Or am I looking at an old version of these patches.

We really shouldn't do that in that flow.  This doesn't make sense on
non-native.

	-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/