linux-kernel - Re: [PATCH v7u1 26/31] x86: Don't enable swiotlb if there is not enough ram for it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE9FiQVCBehZ52p_UdfYbLoB3zJ=41NrQWeNyyCJ483D_9NEmg@mail.gmail.com>
Date:	Tue, 8 Jan 2013 15:40:11 -0800
From:	Yinghai Lu <yinghai@...nel.org>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
Cc:	Shuah Khan <shuahkhan@...il.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...e.hu>, "H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Borislav Petkov <bp@...en8.de>, Jan Kiszka <jan.kiszka@....de>,
	Jason Wessel <jason.wessel@...driver.com>,
	linux-kernel@...r.kernel.org, Joerg Roedel <joro@...tes.org>
Subject: Re: [PATCH v7u1 26/31] x86: Don't enable swiotlb if there is not
 enough ram for it

On Mon, Jan 7, 2013 at 7:50 PM, Yinghai Lu <yinghai@...nel.org> wrote:
> On Mon, Jan 7, 2013 at 7:13 PM, Eric W. Biederman <ebiederm@...ssion.com> wrote:
>> I meant we should detect failure to allocate bounce buffers in in
>> swiotlb_init() instead of panicing.
>>
>> I meant swiotlb_map_single() should either panic or simply fail.
>>
>> If I have read lib/swiotlb.c correctly the only place we allocate a
>> bounce buffer is in swiotlb_map_single.  If there are more places we can
>> allocate bounce buffers those need to be handled as well.
>
> ok, will give it a try.

please check if you are ok with attached.

looks like it need more change of lines.

Thanks

Yinghai

Download attachment "alloc_low_page_nopanic.patch" of type "application/octet-stream" (2534 bytes)

Download attachment "swiotlb.patch" of type "application/octet-stream" (5541 bytes)