linux-kernel - Re: [PATCH] mm: compaction: fix echo 1 > compact

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1301071914460.18525@chino.kir.corp.google.com>
Date:	Mon, 7 Jan 2013 19:15:00 -0800 (PST)
From:	David Rientjes <rientjes@...gle.com>
To:	Jason Liu <r64343@...escale.com>
cc:	linux-kernel@...r.kernel.org, mgorman@...e.de,
	akpm@...ux-foundation.org, riel@...hat.com, minchan@...nel.org,
	kamezawa.hiroyu@...fujitsu.com, linux-mm@...ck.org
Subject: Re: [PATCH] mm: compaction: fix echo 1 > compact_memory return error
 issue

On Sun, 6 Jan 2013, Jason Liu wrote:

> when run the folloing command under shell, it will return error
> sh/$ echo 1 > /proc/sys/vm/compact_memory
> sh/$ sh: write error: Bad address
> 
> After strace, I found the following log:
> ...
> write(1, "1\n", 2)               = 3
> write(1, "", 4294967295)         = -1 EFAULT (Bad address)
> write(2, "echo: write error: Bad address\n", 31echo: write error: Bad address
> ) = 31
> 
> This tells system return 3(COMPACT_COMPLETE) after write data to compact_memory.
> 
> The fix is to make the system just return 0 instead 3(COMPACT_COMPLETE) from
> sysctl_compaction_handler after compaction_nodes finished.
> 
> Suggested-by:David Rientjes <rientjes@...gle.com>
> Cc:Mel Gorman <mgorman@...e.de>
> Cc:Andrew Morton <akpm@...ux-foundation.org>
> Cc:Rik van Riel <riel@...hat.com>
> Cc:Minchan Kim <minchan@...nel.org>
> Cc:KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
> Signed-off-by: Jason Liu <r64343@...escale.com>

Acked-by: David Rientjes <rientjes@...gle.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/