linux-kernel - Re: [PATCH 2/3] ARM: ux500: Turn on the 'heartbeat' LED trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130109103510.GE3931@n2100.arm.linux.org.uk>
Date:	Wed, 9 Jan 2013 10:35:10 +0000
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Lee Jones <lee.jones@...aro.org>, sameo@...ux.intel.com,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linus.walleij@...ricsson.com
Subject: Re: [PATCH 2/3] ARM: ux500: Turn on the 'heartbeat' LED trigger

On Wed, Jan 09, 2013 at 10:18:54AM +0000, Arnd Bergmann wrote:
> On Wednesday 09 January 2013, Lee Jones wrote:
> > diff --git a/arch/arm/mach-ux500/Kconfig b/arch/arm/mach-ux500/Kconfig
> > index 5dea906..0f25b07 100644
> > --- a/arch/arm/mach-ux500/Kconfig
> > +++ b/arch/arm/mach-ux500/Kconfig
> > @@ -43,6 +43,8 @@ config MACH_HREFV60
> >  config MACH_SNOWBALL
> >         bool "U8500 Snowball platform"
> >         select MACH_MOP500
> > +       select LEDS_TRIGGERS
> > +       select LEDS_TRIGGER_HEARTBEAT
> >         help
> >           Include support for the snowball development platform.
> 
> Be careful with "select" statements like this when there are other
> dependencies. I think LEDS_TRIGGERS depends on LEDS_CLASS, so this
> should probably be written as
> 
> 	select LEDS_TRIGGERS if LEDS_CLASS

Umm, this is also wrong for another reason.  LEDS is an optional feature.
It's not required for the platform to be functional.  So why the hell would
anyone want to _force_ such an optional feature to be mandatory?

This is something that the default config published for the platform should
be handling.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/