linux-kernel - Re: [Pv-drivers] [PATCH 07/12] VMCI: queue pairs implementation.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2526541.2xuuOB7vZK@dtor-d630.eng.vmware.com>
Date:	Tue, 08 Jan 2013 16:28:51 -0800
From:	Dmitry Torokhov <dtor@...are.com>
To:	pv-drivers@...are.com
Cc:	Greg KH <gregkh@...uxfoundation.org>,
	George Zhang <georgezhang@...are.com>,
	linux-kernel@...r.kernel.org,
	virtualization@...ts.linux-foundation.org
Subject: Re: [Pv-drivers] [PATCH 07/12] VMCI: queue pairs implementation.

Hi Greg,

On Tuesday, January 08, 2013 04:15:39 PM Greg KH wrote:
> On Tue, Jan 08, 2013 at 03:54:54PM -0800, George Zhang wrote:
> 
> > +/* Guest device port I/O. */
> > +struct PPNSet {
> > +	u64 num_produce_pages;
> > +	u64 num_consume_pages;
> > +	u32 *produce_ppns;
> > +	u32 *consume_ppns;
> > +	bool initialized;
> > +};
> 
> I know this is a private structure to the driver, so it's not that big
> of a deal at all, but the naming for this is a bit odd (mixed case.)
> 
> Not a show stopper at all, but if you had run checkpatch.pl on it, it
> would have warned you about this.

Surprisingly it does not:

[dtor@...r-ws vmci]$ ./scripts/checkpatch.pl -f  
drivers/misc/vmw_vmci/vmci_queue_pair.h 
total: 0 errors, 0 warnings, 191 lines checked

drivers/misc/vmw_vmci/vmci_queue_pair.h has no obvious style problems and is 
ready for submission.

Also silent on the patch itself...

We'll send a followup patch anyway.

Thanks,
Dmitry

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/