linux-kernel - Re: [PATCH] ipmi: replace call to try_smi_init() with call to add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <50ED732B.5070608@redhat.com>
Date:	Wed, 09 Jan 2013 08:39:55 -0500
From:	Tony Camuso <tcamuso@...hat.com>
To:	minyard@....org
CC:	Corey Minyard <tcminyard@...il.com>,
	devicetree-discuss@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
	rob.herring@...xeda.com, openipmi-developer@...ts.sourceforge.net,
	grant.likely@...retlab.ca, k-tanaka@...jp.nec.com,
	myamazak@...hat.com
Subject: Re: [PATCH] ipmi: replace call to try_smi_init() with call to add_smi()

Rescinding.

This hunk is already upstream.

On 01/08/2013 03:12 PM, Tony Camuso wrote:
> Upstream commit 9e368fa0 added function ipmi_pnp_probe(), which
> calls try_smi_init() directly.
>
> try_smi_init() allocates resources for IPMI driver. However
> try_smi_init() can be called again, and the allocated resources
> can be unexpectedly released when the same IPMI resource
> information is found on both ACPI namespace and SMBIOS table.
> ipmi_pnp_probe() should call add_smi() instead of try_smi_init()
>
> For reference, see upstream commit ...
> 2407d77a1a013b88ee3b817f2b934e420e5376f5
>
> Signed-off-by: Tony Camuso <tcamuso@...hat.com>
>
> ---
>   drivers/char/ipmi/ipmi_si_intf.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
> index afb89be..20d13c6 100644
> --- a/drivers/char/ipmi/ipmi_si_intf.c
> +++ b/drivers/char/ipmi/ipmi_si_intf.c
> @@ -2223,7 +2223,7 @@ static int __devinit ipmi_pnp_probe(struct pnp_dev *dev,
>       info->dev = &dev->dev;
>       pnp_set_drvdata(dev, info);
>
> -    return try_smi_init(info);
> +    return add_smi(info);
>
>   err_free:
>       kfree(info);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/