linux-kernel - Re: [PATCH RFT] regulator: lp8788-ldo: Use ldo->en_pin to check if regulator is enabled by external pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130109154008.GB20956@opensource.wolfsonmicro.com>
Date:	Wed, 9 Jan 2013 15:40:09 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	"Kim, Milo" <Milo.Kim@...com>
Cc:	Axel Lin <axel.lin@...ics.com>, "Girdwood, Liam" <lrg@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RFT] regulator: lp8788-ldo: Use ldo->en_pin to check if
 regulator is enabled by external pin

On Wed, Jan 09, 2013 at 02:34:40AM +0000, Kim, Milo wrote:

> -			goto wash;
> +
> +			if (ret == -EBUSY && config->is_gpio_shared)
> +				shared_ena_pin = true;
> +
> +			if (!shared_ena_pin)
> +				goto wash;

It'd be much nicer if we were able to just keep a list of GPIOs
controlling regulators as we see them and automatically work out if
they're shared.  Probably we should just refactor the code so that the
GPIO object is a separate thing rather than just storing the state
directly in the regulator struct.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)