linux-kernel - Re: [PATCH v7u1 26/31] x86: Don't enable swiotlb if there is not enough ram for it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE9FiQUznCR6i56AW6jhiCCK-pQxnAquzxUoWWQamoSC8YAZKA@mail.gmail.com>
Date:	Wed, 9 Jan 2013 09:27:46 -0800
From:	Yinghai Lu <yinghai@...nel.org>
To:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
Cc:	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Shuah Khan <shuahkhan@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...e.hu>, "H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Borislav Petkov <bp@...en8.de>, Jan Kiszka <jan.kiszka@....de>,
	Jason Wessel <jason.wessel@...driver.com>,
	linux-kernel@...r.kernel.org, Joerg Roedel <joro@...tes.org>
Subject: Re: [PATCH v7u1 26/31] x86: Don't enable swiotlb if there is not
 enough ram for it

On Wed, Jan 9, 2013 at 5:24 AM, Konrad Rzeszutek Wilk
<konrad.wilk@...cle.com> wrote:
> On Tue, Jan 08, 2013 at 05:12:02PM -0800, Yinghai Lu wrote:
>> On Tue, Jan 8, 2013 at 5:07 PM, Yinghai Lu <yinghai@...nel.org> wrote:
>> > On Tue, Jan 8, 2013 at 4:58 PM, Eric W. Biederman <ebiederm@...ssion.com> wrote:
>> >
>> >>
>> >> So instead we need to say?
>> >>
>> >> +       if (no_iotlb_memory)
>> >> +               panic("Cannot allocate SWIOTLB buffer");
>> >> +
>> >>
>> >> Which is just making the panic a little later than it used to be and
>> >> seems completely reasonable.
>> >
>> > yes, looks some driver just use map_single without checking results.
>>
>> update one.
>
> Please make it inline.
>

please check updated attached. It should address all your request.

Thanks

Yinghai

Download attachment "swiotlb.patch" of type "application/octet-stream" (6123 bytes)